search

google / blockly-devtools

Tools for Blockly app developers to help build custom blocks.
http://developer.google.com/blockly
Apache License 2.0
60 stars 31 forks source link

Fix: Block edits update JSON definition #275

Closed AnmAtAnm closed 6 years ago

AnmAtAnm commented 6 years ago

Fixes null event listeners, enabling block definition JSON to get updated properly.

First step of fixing #272.

This change is Reviewable

rachel-fenichel commented 6 years ago

Reviewed 1 of 3 files at r1. Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

src/view/app_view.js, line 495 at r1 (raw file):

   * Add event listeners for the block factory.
   */
  // TODO: Move to BlockEditorView or Controller.

Is this associated with one of the issues you just created?

Comments from Reviewable

rachel-fenichel commented 6 years ago
:lgtm:

Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable