search

google / blockly-devtools

Tools for Blockly app developers to help build custom blocks.
http://developer.google.com/blockly
Apache License 2.0
60 stars 31 forks source link

Remove Closure from DevTools #305

Open AnmAtAnm opened 6 years ago

AnmAtAnm commented 6 years ago

Problem statement

DevTools is not a closure-compiled demo, but it is peppered with goog calls: provides, require, and a color picker. Replace this code to eliminate issues like https://github.com/google/closure-library/issues/897.

Consider https://neil.fraser.name/software/colourpicker/ or other color picker available via npm.

(Alternatively... add a compilation step into DevTools, though

Expected Behavior

Code that is never compiled with Closure should not include goog.require and goog.provide statements.

DevTools should not depend on Closure's color picker, since it is not compiled to ensure dependencies are correctly linked/available.

Recompiling main Blockly libraries, if successful, should not change whether Block Factory runs.

Actual Behavior

Recent changes in Closure broke Block Factory (and probably DevTools), even though the Blockly compilation step succeeded.

See https://github.com/google/blockly/issues/1830, https://github.com/google/blockly/issues/1834, https://github.com/google/blockly/issues/668

AnmAtAnm commented 6 years ago

See https://github.com/google/blockly/issues/1834