google / blockly-games

Games for tomorrow's programmers.
https://blockly.games/
Apache License 2.0
1.29k stars 605 forks source link

BUILD / Make deps working, make en or make languages not working? #195

Open ylmzmerttt opened 4 years ago

ylmzmerttt commented 4 years ago

~/blockly-games$ make en mkdir -p appengine/generated/en/ java -jar third-party-downloads/SoyToJsSrcCompiler.jar --shouldProvideRequireSoyNamespaces --isUsingIjData --outputPathFormat appengine/index/generated/en/soy.js --srcs appengine/index/template.soy WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$2 (file:/home/yncsoft/blockly-games/third-party-downloads/SoyToJsSrcCompiler.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$2 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release Exception in thread "main" java.lang.IllegalArgumentException: No enum constant com.google.template.soy.shared.SoyGeneralOptions.CssHandlingScheme.LİTERAL at java.base/java.lang.Enum.valueOf(Enum.java:240) at com.google.template.soy.shared.SoyGeneralOptions$CssHandlingScheme.valueOf(SoyGeneralOptions.java:50) at com.google.template.soy.SoyToJsSrcCompiler.execMain(SoyToJsSrcCompiler.java:279) at com.google.template.soy.SoyToJsSrcCompiler.main(SoyToJsSrcCompiler.java:243) make: *** [Makefile:23: index-en] Error 1

NeilFraser commented 4 years ago

I just tried make clean, make deps, and make en without problems on my machine. No warnings, no errors.

Try executing java -version to see what version of Java you are using. Mine reports:

java version "1.8.0_221"
Java(TM) SE Runtime Environment (build 1.8.0_221-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.221-b11, mixed mode)
mark-friedman commented 4 years ago

Look closely at the 2nd character in "LİTERAL" above. It looks like maybe something got corrupted.

ylmzmerttt commented 4 years ago

I just tried make clean, make deps, and make en without problems on my machine. No warnings, no errors.

Try executing java -version to see what version of Java you are using. Mine reports:

java version "1.8.0_221"
Java(TM) SE Runtime Environment (build 1.8.0_221-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.221-b11, mixed mode)

My java version: openjdk 11.0.7 2020-04-14 OpenJDK Runtime Environment (build 11.0.7+10-post-Ubuntu-3ubuntu1) OpenJDK 64-Bit Server VM (build 11.0.7+10-post-Ubuntu-3ubuntu1, mixed mode, sharing)

huydhoang commented 4 years ago

Hi, I'm running Zulu java 8, Ubuntu 20.04. make deps works fine, but make en or make maze-en threw this: What could be the problem? What is the supported python version?

Compiling Maze - en
third-party-downloads/build/closurebuilder.py: Scanning paths...
third-party-downloads/build/closurebuilder.py: 784 sources scanned.
third-party-downloads/build/closurebuilder.py: Building dependency tree..
Traceback (most recent call last):
  File "third-party-downloads/build/closurebuilder.py", line 300, in <module>
    main()
  File "third-party-downloads/build/closurebuilder.py", line 260, in main
    out.writelines([js_source.GetPath() + '\n' for js_source in deps])
TypeError: a bytes-like object is required, not 'str'
Found 0 dependencies.
NeilFraser commented 4 years ago

@huydhoang That sounds an awful lot like a Python 2 vs Python 3 mismatch. I'll see if I can recreate.

NeilFraser commented 4 years ago

@huydhoang Yes, that's exactly the issue. closurebuilder.py only works with Python 2, when run with Python 3 it blows up. I'll see if I can fix it (that file was created by the Closure team and is deprecated).

In the mean time, you should be able to fix the issue by editing the first line of of third-party-downloads/build/closurebuilder.py from this: #!/usr/bin/env python to this: #!/usr/bin/env python2

JEZIGA01 commented 1 year ago

Watch my video on Youtube step by step 💕 https://youtu.be/uJ9Jz6CeiyE?t=10

My doc: https://gist.github.com/JEZIGA01/dbaedc0fae4b7cde6bddf9b3c5412fe8