google / blockly-games

Games for tomorrow's programmers.
https://blockly.games/
Apache License 2.0
1.29k stars 605 forks source link

Compiling base project's code produces NoneType errors #201

Closed amarrocq closed 4 years ago

amarrocq commented 4 years ago

Describe the bug

Firstly, compiling with make deps throws an error on wget the compiler-latest.zip file.

Now, with dependencies built, compiling with make maze-en throws an error coming from closurebuilder.py : options.excludes : TypeError: argument of type 'NoneType' is not iterable

To Reproduce

  1. Download / clone blockly games
  2. Open terminal
  3. Run make deps (first error appears here)
  4. Run make maze-en
  5. Admire NoneType error

Expected behavior

Compile finishes without error an Blockly Maze can be opened on a server

Desktop OS: Win10 Terminal: Cygwin (with adequate packages)

amarrocq commented 4 years ago

User Baloneo created #204 with the error message pasted.

amarrocq commented 4 years ago

I found a way to go around this problem. I updated my previous PR #203 to take into account my solution. With this updated Makefile you can make deps and make maze-en without errors. Here I assume that the same error was thrown to every blockly-game.