search

google / blockly-games

Games for tomorrow's programmers.
https://blockly.games/
Apache License 2.0
1.29k stars 605 forks source link

Makefile : changed closure-compiler link, which was down and threw an error #203

Closed amarrocq closed 4 years ago

amarrocq commented 4 years ago

Compiling threw an error : closure compiler link is down. Replaced it with latest version link.

google-cla[bot] commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

amarrocq commented 4 years ago

@googlebot I fixed it.

amarrocq commented 4 years ago

201 This is an issue I posted to pursue on the problem I ran accross after fixing this one

NeilFraser commented 4 years ago

Thank you @Seransei for the quick work-around which helped a bunch of developers. I've committed two changes which resolve the issue without pegging Blockly Games to specific versions of the offending dependencies: https://github.com/google/blockly-games/commit/530c6926ed7baf662ad845350ef8b4344e6f482f https://github.com/google/blockly-games/commit/cb9988e9ae696551d0490bc255d0293c817814a2