google / blockly-games

Games for tomorrow's programmers.
https://blockly.games/
Apache License 2.0
1.29k stars 605 forks source link

build error: options.excludes: type 'NoneType' is not iterable #204

Closed byte-voyager closed 4 years ago

byte-voyager commented 4 years ago
➜  google-blockly-games git:(master) ✗ make puzzle-en
java -jar third-party-downloads/SoyToJsSrcCompiler.jar --shouldProvideRequireSoyNamespaces --isUsingIjData --outputPathFormat appengine/generated/en/soy.js --srcs appengine/template.soy
java -jar third-party-downloads/SoyToJsSrcCompiler.jar --shouldProvideRequireSoyNamespaces --isUsingIjData --outputPathFormat appengine/puzzle/generated/en/soy.js --srcs appengine/puzzle/template.soy
python2 build-app.py puzzle en
Scanning for Blockly messages in puzzle...
Compressed to 250 KB.
Found 33 Blockly messages.
Compiling Puzzle - en
third-party-downloads/build/closurebuilder.py: Scanning paths...
Traceback (most recent call last):
  File "third-party-downloads/build/closurebuilder.py", line 300, in <module>
    main()
  File "third-party-downloads/build/closurebuilder.py", line 224, in main
    if js_path not in options.excludes:
TypeError: argument of type 'NoneType' is not iterable
Found 0 dependencies.
Compressed to 251 KB.
amarrocq commented 4 years ago

Hi,

I ran accross the exact same problem which blocks me a lot in my work.

I described it in #201 a few days ago.

If you or anyone happens to solve this problem I'd be glad to hear about it.

Thank you.

amarrocq commented 4 years ago

Hi again,

I found a way to go around this error. I reported what I did in my own issue #201 and put my solution in a PR #203.

Have a good day.

Sachin5411 commented 4 years ago

@Seransei I ran across same problem .. Thanks for the solution , it worked for me :)

NeilFraser commented 4 years ago

Lovely, the Closure Library team made a change that requires '--exclude' be used, even if it is empty. Fixed via https://github.com/google/blockly-games/commit/530c6926ed7baf662ad845350ef8b4344e6f482f

Thanks for the report.