search

google / blockly-games

Games for tomorrow's programmers.
https://blockly.games/
Apache License 2.0
1.29k stars 605 forks source link

Add Inari Sámi to list of languages #235

Closed jhsoby closed 2 years ago

jhsoby commented 2 years ago

Add Inari Sámi, which is above the 25% threshold, to the list of languages for the app. Also change the display name of my native language (Norwegian Bokmål).

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jhsoby commented 2 years ago

I have signed the CLA thing now.

NeilFraser commented 2 years ago

According to our dashboard (which deemphasises the scores of help URLs and tooltips) 'smn' is currently at 53%. Which isn't bad. But our threshold for inclusion is 80%.

I've added the 'Anarâškielâ' name to the code in preparation for its eventual addition. And I've corrected the Norsk language name. Thank you for both of these: https://github.com/google/blockly-games/commit/3e372942c8ae78c140efe57a47fcb5bb8c5145f6

jhsoby commented 2 years ago

Thanks! I'll let the Inari Sámi translators know about the 80 % threshold, I think they are eager to have it included.