google / blockly-keyboard-experimentation

Apache License 2.0
2 stars 4 forks source link

feat: make Blockly cooperative with tab navigation #72

Closed BenHenning closed 2 weeks ago

BenHenning commented 3 weeks ago

Fixes #71

This introduces more intentional tab navigation support in Blockly when using the keyboard navigation plugin, specifically by:

See the following videos for demonstrations on the before/after behavior with these changes:

Before changes:

before_without_reader.webm

After changes:

after_without_reader.webm

Note that there's still a "double tab navigation" issue for the main Blockly injection area with a screen reader (but not for normal navigation). This will require additional investigation outside this PR. The before/after behavior with the screen reader isn't included above since it's hard to see the results in the recording (the highlights and output of the reader aren't being captured).

Note also that this PR also includes a few cleanups:

BenHenning commented 3 weeks ago

PTAL @rachel-fenichel.