Open rachel-fenichel opened 1 year ago
We're not actually running the Closure compiler on these in samples. We should
extends
, etc. where appropriateAlso, an editor might complain with red squiggly lines, but I don't think this is blocking actually running the tests.
@gonfunko were you looking at this one?
I was, but it was pretty rapidly expanding in scope.
Cool, so it's still in the queue
Component
dev-tools
Describe the bug
Some of the types are wrong or don't make sense.
In particular:
block_test_helpers.mocha.js
,CodeGenerationTestCase
is tagged with@implements {TestCase}
, fromcommon_test_helpers.mocha.js
, butTestCase
is a class, not an interface.FieldValueTestCase
FieldCreationTestCase
is tagged with@extends {FieldValueTestCase}
, but doesn't haveextends
in the class declaration (or asuper()
call in the constructor.populateRandom
inpopulate_random.js
has a parameter of typeBlockly.Workspace
but it should be aBlockly.WorkspaceSvg
--we assume it is later, when callinginitSvg()
and similar functions on the return value ofworkspace.newBlock()
.screenshot.js
is doing some things that I don't understand withRect
objects.Additional information @NeilFraser found these issues while working on fields.