google / blockly-samples

Plugins, codelabs, and examples related to the Blockly library.
http://github.com/google/blockly
Apache License 2.0
850 stars 624 forks source link

Update continuous toolbox plugin for flyout API changes #2464

Open gonfunko opened 1 month ago

gonfunko commented 1 month ago

Check for duplicates

Component

Continuous Toolbox plugin

Description

The flyout API is changing in Blockly v12 (see https://github.com/google/blockly/pull/8601), and the continuous toolbox plugin will need to be updated for compatibility. Most of the needed changes have already been made in https://github.com/gonfunko/scratch-blocks/pull/209#pullrequestreview-2352707135 and will just need to be backported, but we'll need to coordinate merging/publishing to coincide with the v12 release.

Reproduction steps

No response

Stack trace

No response

Screenshots

No response

gonfunko commented 1 month ago

ContinuousToolbox.getInitialFlyoutContents_() should also be refactored to allow subclasses to make changes. It should probably call a conversion function for each item, which subclasses could override to support additional types of flyout items or just delegate to super.