search

google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.37k stars 3.69k forks source link

Upstream scratch-blocks fixes for workspace comments #2724

Closed rachel-fenichel closed 1 year ago

rachel-fenichel commented 5 years ago

This is a tracking bug for multiple recent fixes for workspace comments that scratch-blocks made. We'll want to pull these in, but it's not yet high priority.

https://github.com/LLK/scratch-blocks/pull/1970 https://github.com/LLK/scratch-blocks/pull/1967

@kchadha @picklesrus @paulkaplan Please add any that I've missed.

rachel-fenichel commented 5 years ago

https://github.com/LLK/scratch-blocks/pull/1971

samelhusseini commented 5 years ago

https://github.com/microsoft/pxt-blockly/pull/243

kchadha commented 5 years ago

@samelhusseini, we just looked into the same delete touch gesture bug and we ended up fixing it a slightly different way: https://github.com/LLK/scratch-blocks/pull/1970/files#diff-c7bb21e1a4838f04477d19d4b3d4e816R100

bindEventWithChecks_ has extra flags for not capturing the touch identifier.

samelhusseini commented 5 years ago

Awesome thanks for pointing that out @kchadha. @shakao FYI

rachel-fenichel commented 5 years ago

https://github.com/LLK/scratch-blocks/pull/1975

rachel-fenichel commented 1 year ago

I'm referencing this in the tracking bug for splitting out workspace comments, but closing it because the fixes are no longer directly applicable (we can't just pull them upstream, given changes since this issue was filed).