Modularlize more of Blockly

google / blockly

The web-based visual programming editor.

https://developers.google.com/blockly/

Apache License 2.0

12.49k stars 3.71k forks source link

Modularlize more of Blockly #3023

Open samelhusseini opened 5 years ago

samelhusseini commented 5 years ago

Using this issue to track work for splitting out Blockly into more modular components. Renderers and fields are already fairly modular, we'll need to run a cost-benefit analysis of how easy it is to modularize more of Blockly. Some candidates:

[ ] Toolbox
[ ] Block comments
[ ] Workspace comments
[ ] Horizontal flyouts
[ ] Vertical flyouts
[ ] Flyout buttons
[ ] Generators
[ ] Procedures
[ ] Variables
[ ] Dynamic Variables
[ ] Grid
[ ] Keyboard_nav (93kb raw sources)
[ ] Field types
[ ] Mutators
[ ] Warnings
[ ] Trashcan
[ ] Zoom Controls

RoboErikG commented 5 years ago

Note on the help wanted tag, some of these should be easy like #3053 but not all of them.

NeilFraser commented 5 years ago

Related PRs so far:

Trash can and zoom controls: #3043
Mutators: #3048
Block comments: #3053
Toolbox: #3055
Flyout Buttons: #3076 and #3080
CSS: #3084
Dynamic Variables: #3101
Horizontal & Vertical Flyouts: https://github.com/google/blockly/commit/ddb8e46b87c315e5194e87d6fc3bb2a67a192477

cpcallen commented 3 years ago

Most or all of these (notably including Blockly.Trashcan) have ceased to be optional due to the work done to re-export `Blockly.incore/blockly.js`. 🤔

(* Noted while investigating issues with building Blockly Games.)

NeilFraser commented 2 years ago

Unchecking all the progress we've made (14 out of 17) due to the TypeScript migration. We're back to square one.

rachel-fenichel commented 2 years ago

Hang on, I consider it still modularized if it's registrable. There are two parts we're talking about:

Make pieces registrable
Make pieces removable

The first one focuses on modularization for API boundaries, and we've made a lot of progress there. The second one focuses on size.