Context menu font does not match workspace theme

google / blockly

The web-based visual programming editor.

https://developers.google.com/blockly/

Apache License 2.0

12.38k stars 3.7k forks source link

Context menu font does not match workspace theme #3764

Open rachel-fenichel opened 4 years ago

rachel-fenichel commented 4 years ago

Describe the bug

The context menu does not scale when the workspace is zoomed. Neither do other instances of goog.ui.Menu, such as dropdown menus.

It's not clear what the correct solution is here. For instance, context menus in Chrome don't scale with page zoom.

Open questions:

Should the context menu scale?
Should dropdowns have a developer API to indicate whether they should scale?

rachel-fenichel commented 1 year ago

Context menus should not scale with workspace zoom, to match browser behaviour. But they should match the font size of the rest of Blockly, which means they should change based on the workspace theme.