google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.4k stars 3.7k forks source link

Zelos hides disabled blocks placeholders #7428

Open clementcontet opened 1 year ago

clementcontet commented 1 year ago

Check for duplicates

Description

When a block is disabled, Zelos doesn't show the placeholders (not sure about the correct name...), so it is very hard to connect disabled blocks together.

Strangely, the placeholders reappear when we open the toolbox.

Geras doesn't have this problem: placeholders are always visible.

NB: overriding style fixes the issue:

.blocklyDisabled > .blocklyOutlinePath {
  fill: darkgray !important;
}

Reproduction steps

No response

Stack trace

No response

Screenshots

https://github.com/google/blockly/assets/7261426/ea55f3b6-9db5-4d2c-8706-d8e42858d463

Browsers

Chrome desktop

surajguduru commented 1 month ago

Hey @BeksOmega I would to work on this issue. Can you assign it to me ?

BeksOmega commented 1 month ago

@surajguduru This isn't a good-first-issue which means it will require doing some investigation and learning the internals of Blockly. Are you still interested in working on it?

surajguduru commented 1 month ago

Yes. I would like to give it a shot.

BeksOmega commented 1 month ago

Ok go for it @surajguduru