search

google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.35k stars 3.7k forks source link

Rename `editing` CSS class to `blocklyEditing` #8287

Closed BeksOmega closed 1 month ago

BeksOmega commented 1 month ago
  1. In the widgetCreate_ method on the FieldInput change the editing string passed to dom.addClass to blocklyEditing.
  2. Also change references to editing in the common renderer CSS and the zelos renderer CSS to blocklyEditing.

This should be merged into the rc/v12.0.0 branch. It should be marked as breaking.

If you want to work on this, comment below to be assigned this issue.

ga-fleury commented 1 month ago

Hello, I would like to work on this

BeksOmega commented 1 month ago

Go for it @ga-fleury ! Let me know if you have any questions =)

ga-fleury commented 1 month ago

@BeksOmega opening pull request for this issue

BeksOmega commented 1 month ago

@BeksOmega I don't think I have permission to push to the rc/v12.0.0 branch

Oh yeah, the correct flow is to use a pull request. You should create a branch off of rc/v12.0.0, make your changes, and then put up a pull request against rc/v12.0.0. See our contributing docs for more info.

ga-fleury commented 1 month ago

missing CLA, opening new PR

ga-fleury commented 1 month ago

@BeksOmega I think everything is OK now, took me some time to figure out the correct PR workflow

ga-fleury commented 1 month ago

@BeksOmega finally got it

BeksOmega commented 1 month ago

Closed by #8301