google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.53k stars 3.72k forks source link

feat: implement `WorkspaceSvg` class manipulation #8473

Closed UCYT5040 closed 3 months ago

UCYT5040 commented 3 months ago

The basics

The details

Resolves

Fixes #8281

Proposed Changes

Implements addClass and removeClass methods to the WorkspaceSvg class.

Reason for Changes

As requested in #8281

Test Coverage

Ran the usual build/test scripts and also made sure it worked okay in the playground.

Documentation

Yes, add docs for the new methods

Additional Information

conventional-commit-lint-gcf[bot] commented 3 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

UCYT5040 commented 3 months ago

I accepted both of those. Sorry about those commit names- I didn't notice that it was using the default name when accepting the suggestion.

BeksOmega commented 3 months ago

No worries at all! Thank you for your work on this =)