search

google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.52k stars 3.72k forks source link

fix: clear touch identifier on comment icon down #8627

Closed riknoll closed 4 weeks ago

riknoll commented 1 month ago

The basics

The details

Resolves

Fixes https://github.com/google/blockly/issues/8626

Proposed Changes

Calls clearTouchIdentifier() inside the two pointerdown events for the workspace comment icons inside the CommentView class.

Reason for Changes

The two icon pointerdown event handlers inside the workspace CommentView don't ever clear the touch identifier. Click events should always call that function when bound with conditionalBind or else they leave behind an orphaned touchIdentifier that prevents all further events from firing.

Test Coverage

N/A

Documentation

N/A

Additional Information

Tested on the iPad simulator using ios 18.0

gonfunko commented 4 weeks ago

Thank you!

riknoll commented 4 weeks ago

thanks for the quick review @gonfunko! do you know when this is going to be released? we have a makecode release coming up and we expect a lot of customers will hit this (many of our testers have)

gonfunko commented 3 weeks ago

I'm hoping to do a point release of v11 including this change in the next couple weeks.