search

google / brax

Massively parallel rigidbody physics simulation on accelerator hardware.
Apache License 2.0
2.25k stars 249 forks source link

Writer: replace add_scalars with add_scalar #307

Closed gijskoning closed 1 year ago

gijskoning commented 1 year ago

Both functions show the logged values in Tensorboard, however 'add_scalar' is much cleaner: Previously add_scalars would create a new run folder for each tag, and the description would contain the key twice (e.g. key='eval/reward' results in description: run/eval/reward/eval/reward). This resulted in Tensorboard showing multiple runs while actually only doing a single run with different tags.

The new method can be combined with the old method since both will still write to the same summaryboard.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

erikfrey commented 1 year ago

Good find, thank you!