google / brax

Massively parallel rigidbody physics simulation on accelerator hardware.
Apache License 2.0
2.25k stars 249 forks source link

fix camera z fighting bug in viewer #330

Closed nickav closed 1 year ago

nickav commented 1 year ago

This fixing a depth fighting / flickering issue in the viewer when objects are clipping through the ground plane.

Before:

https://user-images.githubusercontent.com/5448363/230492454-8d1609b0-cf2a-4fa2-9ef0-4a5176e61da9.mp4

After:

https://user-images.githubusercontent.com/5448363/230492474-714f9e10-4d43-4457-95e1-7ac68901737a.mp4

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

btaba commented 1 year ago

Thanks @nickav for fixing this issue!