google / brax

Massively parallel rigidbody physics simulation on accelerator hardware.
Apache License 2.0
2.14k stars 234 forks source link

`mjx.ncon` removed as of MuJoCo 3.1.5 #485

Closed namheegordonkim closed 1 month ago

namheegordonkim commented 1 month ago

Hi friends,

It appears that MuJoCo officially removed mjx.ncon (https://mujoco.readthedocs.io/en/latest/changelog.html#version-3-1-5-may-7-2024) and hence this line is broken:

https://github.com/google/brax/blob/b45760cfa6ba0c3567ae36f988766a8299853c49/brax/contact.py#L38

Should be a quick fix; perhaps L38 should be replaced by

mujoco.MjData(sys.mj_model).ncon

or something cleverer.

btaba commented 1 month ago

Hi @namheegordonkim , we have a release in the backlog that we'll push out shortly! Apologies

btaba commented 1 month ago

See https://github.com/google/brax/releases/tag/v0.10.4 for the latest release. Thanks for the ping @namheegordonkim