Closed trevormcinroe closed 2 weeks ago
The javascript used to render trajectories in the html viewer accesses the geoms attribute of a given system object: https://github.com/google/brax/blob/main/brax/visualizer/js/system.js#L160C17-L160C35
geoms
This rendering process appears to be triggered when loading a file saved via the brax.io.html.save() function: https://github.com/google/brax/blob/main/brax/io/html.py#L29, which takes a brax.base.System object.
brax.io.html.save()
brax.base.System
However, since the geoms attribute was removed from brax.base.System, what geoms attribute is the javascript rendering process accessing? The rendering appears to work, but it is not clear how.
Hi @trevormcinroe, geoms is created here https://github.com/google/brax/blob/f43727eeebf21c031faf861ee00e98919c892140/brax/io/json.py#L152
Hope that helps
The javascript used to render trajectories in the html viewer accesses the
geoms
attribute of a given system object: https://github.com/google/brax/blob/main/brax/visualizer/js/system.js#L160C17-L160C35This rendering process appears to be triggered when loading a file saved via the
brax.io.html.save()
function: https://github.com/google/brax/blob/main/brax/io/html.py#L29, which takes abrax.base.System
object.However, since the
geoms
attribute was removed frombrax.base.System
, whatgeoms
attribute is the javascript rendering process accessing? The rendering appears to work, but it is not clear how.