google / brotli-wheels

Brotli wheels
MIT License
10 stars 16 forks source link

update BUILD_COMMIT env var to point to 'v1.0.1' tag #4

Closed anthrotype closed 6 years ago

anthrotype commented 6 years ago

Simply updating the git submodule as @eustas did with #3 is not enough to trigger our multibuild setup to build from the new commit. You can see that Travis and Appveyor are still building the previous "v0.6.0" tagged commit:

https://travis-ci.org/google/brotli-wheels/jobs/279488585#L484

Also, note the generated wheels have version 0.6.0 in their file names. https://ci.appveyor.com/project/szabadka/brotli-wheels/build/1.0.0%238/job/e936y05pib1k768o/artifacts

In order to have multibuild run the build from a specific commit, you have to point to that commit with the BUILD_COMMIT environment variable. The current commit of the git submodule does not make any difference actually, since the BUILD_COMMIT is always checked out before a build, so next time it's sufficient to just change the latter.

eustas commented 6 years ago

Thanks