google / brunsli

Practical JPEG Repacker
MIT License
730 stars 51 forks source link

Fix for macOS #63

Closed proyb6 closed 4 years ago

proyb6 commented 4 years ago

Replace -gc-sections with -dead_strip option to fix compilation error.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

eustas commented 4 years ago

I'm afraid, it will break builds that use GNU ld. Makefile is deliberately minimalistic and works only well only in a subset of environments. Please consider using modern build systems, like CMake or Bazel.