search

google / btree

BTree provides a simple, ordered, in-memory data structure for Go programs.
Apache License 2.0
3.9k stars 414 forks source link

v2 release with generic approach #43

Closed Michal-Leszczynski closed 2 years ago

Michal-Leszczynski commented 2 years ago

Fixes #41

hawkingrei commented 2 years ago

@Michal-Leszczynski We are all looking forward to merging this pr.

gconnell commented 2 years ago

Rather than create a /v2/, I propose with https://github.com/google/btree/pull/45 that we simply create a generic interface as well as the non-generic, backwards-compatible Item interface, and use that for Go 1.18 and beyond to implement the backwards-compatible Item interface. Thoughts?

gconnell commented 2 years ago

Closing as #45 I believe handles this same issue. If there's any issues with that or it fails to work correctly, though, happy to reopen this.