search

google / btree

BTree provides a simple, ordered, in-memory data structure for Go programs.
Apache License 2.0
3.9k stars 414 forks source link

fix: re-add `Has` method for a `BTreeG[Item]` #48

Closed julienrbrt closed 2 years ago

julienrbrt commented 2 years ago

Re-add the Has method for a BTree. 1.1.0 is breaking due to that being missing.

https://github.com/cosmos/cosmos-sdk/pull/12163

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

twpayne commented 2 years ago

@julienrbrt would you be able to sign the CLA? I need the same fix.

julienrbrt commented 2 years ago

@julienrbrt would you be able to sign the CLA? I need the same fix.

I think I have already done it :) https://github.com/google/btree/pull/48/checks

gconnell commented 2 years ago

Thanks! Added in coverage of Has in tests to avoid similar regressions later on, with https://github.com/google/btree/commit/8e29150ba321eef204059de2ab494f179b6cff2c. Tagging as v1.1.2