search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.15k stars 2.32k forks source link

Make Docker APIs in manager generic #1276

Closed sjpotter closed 8 years ago

sjpotter commented 8 years ago

I see a handful of APIs that are docker specific

AllDockerContainers(query info.ContainerInfoRequest) (map[string]info.ContainerInfo, error) DockerContainer(dockerName string, query info.ContainerInfoRequest) (info.ContainerInfo, error) DockerInfo() (info.DockerStatus, error) DockerImages() ([]info.DockerImage, error)

I'm honestly unsure how t ohandle DockerInfo(), but the rest are probably along the lines of

AllNamespacedContainers(containerNamespace string, query *info.ContainerInfoRequest)

NamespacedContainer(containerName string, containerNamespace string, query *info.ContainerInfoRequest)

RuntimeImages(containerNamespace string)

timstclair commented 8 years ago

Duplicate of https://github.com/google/cadvisor/issues/1177