search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.79k stars 2.3k forks source link

Migrate off the deprecated package `golang.org/x/exp/inotify` #1708

Open yujuhong opened 7 years ago

yujuhong commented 7 years ago

golang.org/x/exp/inotify has been deleted (see https://github.com/golang/exp/tree/master/inotify) cadvisor should switch to using fsnotify, or something equivalent.

xref: https://github.com/kubernetes/kubernetes/issues/40123

dashpole commented 6 years ago

reopening via #1807. Issue: https://github.com/kubernetes/kubernetes/issues/55909

dashpole commented 6 years ago

It looks like the switch to fsnotify actually worked... The summary test passes if we use a non-restarting pod, but fails with the current version of the test. The test checks the summary api for pods that restart. But when they restart, we loose metrics for it. I am not sure how it passes when we are using inotify...

dashpole commented 5 years ago

We are still using inotify. Reopening

ElCoyote27 commented 4 years ago

@dashpole Still fails on RHEL7, see https://github.com/google/cadvisor/issues/1843