search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.11k stars 2.32k forks source link

Adding Power support for Cadvisor image #2287

Open lysannef opened 5 years ago

lysannef commented 5 years ago

Hi All,

The images available here - https://hub.docker.com/r/google/cadvisor have support for "amd64" only as seen below

docker inspect google/cadvisor:latest | grep Arch "Architecture": "amd64",

I was able to build this image locally on a Power machine using the dockerfile and validate it successfully and was looking for help in making the official image on dockerhub, multi-arch.

Thank you!!

dashpole commented 5 years ago

cc @bentheelder Do we have support for mult-arch builds in k8s that we could use to solve this?

BenTheElder commented 5 years ago

I wouldn't necessarily re-use any of the k8s build tooling, but we do cross compile to many architectures including PPC64LE.

lysannef commented 5 years ago

@dashpole Have there been any discussions on taking this forward?

dashpole commented 5 years ago

I don't think we would push images we haven't built ourselves. If there is a way to do a containerized multi-arch build (so we can build it without a power machine), we could consider adding that functionality to cAdvisor's build scripts, and making it part of the release. I don't really have any bandwidth to tackle it, but I would be happy to review changes.

I can't guarantee the image will be pushed to dockerhub, as I seem to have lost access. But it would still exist on k8s.gcr.io.

lysannef commented 5 years ago

@dashpole Thanks for the updates! We will work on getting a containerized multi-arch build and will raise a PR for the same.