search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.15k stars 2.32k forks source link

the tag of cadvisor in kubernetes #2500

Open lubinsz opened 4 years ago

lubinsz commented 4 years ago

Hi all, Currently, the version of cadvisor in kubernetes is v0.36.1-0.20200323171535-8af10c683a96. Please see the link as reference: https://github.com/kubernetes/kubernetes/blob/master/vendor/modules.txt#L351 There is a problem with this version, which will cause kubernetess can't be started on arm VM-s. And this issue has been fixed by my PR: https://github.com/google/cadvisor/pull/2456 So, can we add a new tag for cAdvisor, such as 3.36.1 or 3.36.2 ? so that I can use this new tag in kubernetes and fix this issue in k8s side.

Thanks.

lubinsz commented 4 years ago

cc @dashpole @dims

dims commented 4 years ago

We are not ready for this yet @lubinsz we are in the middle of updating both cadvisor and k/k to klog v2.

lubinszARM commented 4 years ago

@dims Any updates?

dims commented 4 years ago

Follow along here: https://github.com/kubernetes/kubernetes/pull/90183

hakman commented 4 years ago

@dims the klog v2 change seem to be done. Would it still be possible to update the cAdvisor version from k8s 1.19? I am mainly interested in getting https://github.com/google/cadvisor/pull/2586. Thanks!

dims commented 4 years ago

latest effort is here @hakman : https://github.com/kubernetes/kubernetes/pull/91366

hakman commented 4 years ago

Thanks @dims.