google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.11k stars 2.32k forks source link

extend cadvisor.GetDirFsInfo to handle GetDirFsInfo failure #3234

Open pacoxu opened 1 year ago

pacoxu commented 1 year ago
          @pacoxu I was suggesting to extend cadvisor.GetDirFsInfo to handle this error instead of handling it on the caller side.

_Originally posted by @bart0sh in https://github.com/kubernetes/kubernetes/pull/113192#discussion_r1070265297_

I opened https://github.com/kubernetes/kubernetes/pull/113192/files in k/k to fix it in caller side. However, this may be not that graceful.

So I open this issue to track the issue in the cadvisor side. I will submit a PR for this later.

The linked K/K issue is https://github.com/kubernetes/kubernetes/issues/113066.

pacoxu commented 7 months ago

/cc @bobbypage

many kube user met this issue https://github.com/kubernetes/kubernetes/issues/113066. Is this a known issue?