search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.97k stars 2.31k forks source link

[Feature Request] Allow customization of Container Plugins #3342

Open spartan0x117 opened 1 year ago

spartan0x117 commented 1 year ago

Hello! The Grafana Agent currently embeds cAdvisor to allow for the collection of container metrics. I am happy to make the changes, but I wanted to check in first to see if you're open to allowing for customization and passing of values such as the Docker Endpoint, TLS, etc.. and similar values for containerd.

This would also mean changing the client be cached once per unique combination of values, rather than once globally (as it is now).

Thank you and looking forward to your thoughts!

iwankgb commented 1 year ago

Looks like a reasonable idea to me. The only important caveat is, as far as I understand, that default configuration values must match whatever is used at the moment.