search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.85k stars 2.31k forks source link

Default image on gcr.io downloads a 3 year old image #3363

Open haurog opened 1 year ago

haurog commented 1 year ago

gcr.io/cadvisor/cadvisor pulls a 3 year old version of cadvisor (v0.38.6).

Expected behaviour: Pull the latest version (v0.47.2).

Actual behaviour: Pulls version v0.38.6

The 'latest' tag seems to not have been updated since December of 2020. This results in downstream projects to have to update the version of the docker images manually. See the following commit as an example: https://github.com/eth-educators/eth-docker/commit/6c1ec3922938b260120eb7b6eb6e6bd743dcf607

iwankgb commented 1 year ago

@bobbypage, can you take a look, please?

frenkye commented 1 year ago

It is a bit confusing, but there was issue that latest no longer will be updated, which i have no problem with, but i think it should be removed if not updated at least to remove confusion.

https://github.com/google/cadvisor/issues/2412

Not to mention, it was updated since this issue 😅

haurog commented 11 months ago

Agree with you, having a 'latest' tag only makes sense if one actually updates it. If regularly updating the 'latest' tag is still no option I would guess removing it would probably be the way to go. I am curious how many projects just use 'latest' and are not aware that they are using a pretty old version of cadvisor.

bboreham commented 10 months ago

Little bit of background info:

2412 was closed with a PR to update the documentation saying latest is no longer updated.

Unfortunately that documentation was removed in #3141.

DerJJ commented 9 months ago

Don't be the unicorn and do some weird other thing of an otherwise common used principle, please fix this! I'm a grown man, I can decide on my own if I want the latest version or a fixed version. Don't gaslight others with "While the latest tag is convenient for getting started, it comes with some downsides, which are well documented elsewhere." stuff...

Logicer16 commented 1 month ago

The latest tag has now been updated with v0.49.1: https://console.cloud.google.com/gcr/images/cadvisor/global/cadvisor@sha256:3cde6faf0791ebf7b41d6f8ae7145466fed712ea6f252c935294d2608b1af388/details.

Update: This may have been a one-off and not a change of process/policy as v0.50.0 has not (yet) received the same treatment.

rc5hack commented 1 month ago

new docker images is now in registry, latest now is 0.49.1

seems to be solved