search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.01k stars 2.31k forks source link

Add s390/s390x CPU topology #3516

Closed madeelibm closed 3 months ago

madeelibm commented 5 months ago

s390x CPU topology is missing in cadvisor which made kubelet service returns error when enabling CPU Manager. This patch adds missing CPU topology with which CPU Manager can also be enabled on s390x platform. Please for review and if there are concerns let us know.

k8s-ci-robot commented 5 months ago

Hi @madeelibm. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
madeelibm commented 5 months ago

@bobbypage We are adding support for s390x again with the PR: https://github.com/google/cadvisor/pull/3521

madeelibm commented 4 months ago

Can someone help to merge this PR?

haircommander commented 4 months ago

/ok-to-test

k8s-ci-robot commented 4 months ago

@haircommander: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/google/cadvisor/pull/3516#issuecomment-2137398338): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mrunalp commented 4 months ago

/ok-to-test

haircommander commented 4 months ago

you have some test failures that need fixing @madeelibm

in the meantime @iwankgb @bobbypage PTAL

madeelibm commented 3 months ago

/retest

madeelibm commented 3 months ago

/retest

madeelibm commented 3 months ago

/retest

madeelibm commented 3 months ago

All tests are passing now on x86 and Z.

haircommander commented 3 months ago

@iwankgb PTAL

iwankgb commented 3 months ago

@madeelibm, can you merge master, please?

iwankgb commented 3 months ago

/retest