google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.6k stars 2.29k forks source link

Add s390x support again #3521

Open madeelibm opened 2 months ago

madeelibm commented 2 months ago

thin-provisioning-tools package is now available in Alpine Linux. We have tested and added it in latest, 3.19 and 3.18 releases.

k8s-ci-robot commented 2 months ago

Hi @madeelibm. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
madeelibm commented 1 month ago

Can someone help to merge this PR?

mrunalp commented 1 month ago

Looks fine. I have kicked off the tests.

rphillips commented 1 month ago

The failed test is a package manager flake.

LGTM as well.

haircommander commented 1 month ago

@iwankgb @bobbypage PTAL

madeelibm commented 6 days ago

/retest

k8s-ci-robot commented 6 days ago

@madeelibm: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/google/cadvisor/pull/3521#issuecomment-2194573182): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iwankgb commented 5 days ago

@madeelibm merge master, please

iwankgb commented 5 days ago

/ok-to-test