use containerd/containerd/api module

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.

Other

16.6k stars 2.29k forks source link

use containerd/containerd/api module #3526

Open akhilerm opened 2 months ago

akhilerm commented 2 months ago

use containerd/containerd/api module instead of having a copy in third_party
use containerd/errdefs module instead of keeping a local copy

k8s-ci-robot commented 2 months ago

Hi @akhilerm. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

bobbypage commented 2 months ago

/ok-to-test

bobbypage commented 2 months ago

Very exciting to see this happen!

akhilerm commented 2 months ago

@bobbypage Can you approve the github action workflows also?

dims commented 2 months ago

/ok-to-test

akhilerm commented 1 month ago

/cc @bobbypage @dims for review

akhilerm commented 1 month ago

/hold will merge once containerd/containerd/api v1.8.0 is released

akhilerm commented 1 week ago

@bobbypage Can you approve the workflow. I have rebased against the latest master branch

iwankgb commented 1 week ago

@akhilerm, you have conflicts against master.

akhilerm commented 1 week ago

rebased against master and pushed the changes.

akhilerm commented 1 week ago

The pull-cadvisor-e2e job is failing due to env setup error

/retest pull-cadvisor-e2e

k8s-ci-robot commented 1 week ago

@akhilerm: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test pull-cadvisor-e2e

Use /test all to run all jobs.

In response to [this](https://github.com/google/cadvisor/pull/3526#issuecomment-2184133012): >The `pull-cadvisor-e2e ` job is failing due to env setup error > >/retest pull-cadvisor-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

akhilerm commented 1 week ago

/test pull-cadvisor-e2e

akhilerm commented 1 week ago

/test pull-cadvisor-e2e

akhilerm commented 4 days ago

/hold

for https://github.com/containerd/typeurl/pull/45 to merge