google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.01k stars 2.31k forks source link

fix: update very old test infra image #3527

Closed bluestealth closed 3 months ago

bluestealth commented 5 months ago
google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

k8s-ci-robot commented 5 months ago

Hi @bluestealth. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akhilerm commented 4 months ago

/cc @bobbypage

akhilerm commented 4 months ago

/ok-to-test

k8s-ci-robot commented 4 months ago

@akhilerm: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/google/cadvisor/pull/3527#issuecomment-2106105535): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iwankgb commented 4 months ago

/ok-to-test

dims commented 3 months ago

/retest

bobbypage commented 3 months ago

https://github.com/google/cadvisor/pull/3540 was merged which updates the image used as well.

bluestealth commented 3 months ago

Given #3540 is merged feel free to close

bobbypage commented 3 months ago

Given #3540 is merged feel free to close

Thank you for your help here!