google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.6k stars 2.29k forks source link

Misleading name of container_memory_failures_total metric #3535

Open AlexZzz opened 4 weeks ago

AlexZzz commented 4 weeks ago

Hi! Metric container_memory_failures_total has a misleading name and description: Cumulative count of memory allocation failures. Page faults are not failures actually. Reading the name of this metric makes me think about SIGSEGV or OOM, but not about page faults.

It also unclear for people who are not familiar with memory management.

It would be better to name it: container_memory_page_faults_total and make label type: minor|major

I understand that this is a breaking change:) creating this issue as a suggestion and for feature searchers.