google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
16.6k stars 2.29k forks source link

K8s/cri-o broken for cgroup-driver != systemd #3538

Open uablrek opened 3 weeks ago

uablrek commented 3 weeks ago

This:

https://github.com/google/cadvisor/blob/54dff2b8ccb147747d814b0ff3b4a3256dc569c0/container/crio/factory.go#L131-L134

checks for .scope suffix, but that is unique for cgroup-driver=systemd (systemd.scope.5).

This causes K8s systems with cri-o to fail getting pod/container metrics in K8s v1.30+ if --cgroup-driver=cgroupfs is used (which is the default).

Ref https://github.com/cri-o/cri-o/issues/8034