search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.01k stars 2.31k forks source link

Revert to docker/docker 26.1.4 #3553

Closed skitt closed 3 months ago

skitt commented 3 months ago

27.0.0 was withdrawn, see https://github.com/moby/moby/issues/47980

cadvisor can’t currently be built except on systems that have 27.0.0 in their cache. The tag was created by mistake instead of an RC tag.

k8s-ci-robot commented 3 months ago

Hi @skitt. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skitt commented 3 months ago

/cc @dims

dims commented 3 months ago

/approve /lgtm

skitt commented 3 months ago

/cc @iwankgb @bobbypage

dims commented 3 months ago

@skitt waiting for the pull-cadvisor-e2e to finish.

skitt commented 3 months ago

Ah, right, sorry — I didn’t realise it was running (GH just shows me “expected”).

dims commented 3 months ago

/test pull-cadvisor-e2e

dims commented 3 months ago

weird that i had to force it to run...

skitt commented 3 months ago

/test pull-cadvisor-e2e

k8s-ci-robot commented 3 months ago

@skitt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/google/cadvisor/pull/3553#issuecomment-2186794712): >/test pull-cadvisor-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iwankgb commented 3 months ago

/ok-to-test