google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.01k stars 2.31k forks source link

Add uninterruptible metric load d #3555

Closed j4ckstraw closed 2 months ago

j4ckstraw commented 3 months ago

Currently container_cpu_load_average_10s only trace running tasks, we need uninterruptible metric to find out offline load too. Here I add a metric named load.d

see https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup-v1.c#L724C1-L743C3

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

k8s-ci-robot commented 3 months ago

Hi @j4ckstraw. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iwankgb commented 3 months ago

/ok-to-test

iwankgb commented 2 months ago

@j4ckstraw you may need to merge master, I think.

j4ckstraw commented 2 months ago

@j4ckstraw you may need to merge master, I think.

done. thank you for your comment.

j4ckstraw commented 2 months ago

thanks @wenjianhn for the idea of load.d