search

google / cadvisor

Analyzes resource usage and performance characteristics of running containers.
Other
17.23k stars 2.33k forks source link

Replace `commonLabels` with `labels` #3603

Open JoeyC-Dev opened 1 month ago

JoeyC-Dev commented 1 month ago

Proposed change: Replaced the deprecated commonLabels with labels

Supporting point: Currently, if executing the following command, the error will pop:

VERSION=v0.49.1
kustomize build "https://github.com/google/cadvisor/deploy/kubernetes/base?ref=${VERSION}" | kubectl apply -f -
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Justification of the change: In my consideration, both includeSelectors and includeTemplates are not needed. It does work without using them. But the behaviour of commonLabels (referring to old method) will use includeSelectors and includeTemplates mandatory, while these are not necessary at all. If the team believes includeSelectors and includeTemplates are needed, please comment so and I will add them.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.