google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
494 stars 67 forks source link

Fix image ID parsing in modern Docker #109

Closed sritchie closed 1 year ago

sritchie commented 1 year ago

This PR:

codecov[bot] commented 1 year ago

Codecov Report

Merging #109 (cadd75b) into master (56f96e7) will decrease coverage by 2.87%. The diff coverage is 35.41%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   55.72%   52.85%   -2.87%     
==========================================
  Files          31       33       +2     
  Lines        3180     3557     +377     
==========================================
+ Hits         1772     1880     +108     
- Misses       1408     1677     +269     
Impacted Files Coverage Δ
caliban/platform/run.py 28.44% <0.00%> (ø)
caliban/util/fs.py 90.56% <ø> (ø)
caliban/docker/build.py 32.56% <33.33%> (-0.15%) :arrow_down:
caliban/resources/caliban_launcher.py 96.72% <60.00%> (-3.28%) :arrow_down:

... and 8 files with indirect coverage changes