search

google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
492 stars 67 forks source link

Prevent mlflow env vars from being generated when there is no mlflow config #81

Closed ajslone closed 4 years ago

ajslone commented 4 years ago

This PR prevents mlflow environment variables from being generated when there is no mlflow configuration in .calibanconfig.json.

codecov[bot] commented 4 years ago

Codecov Report

Merging #81 into master will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   51.80%   51.93%   +0.12%     
==========================================
  Files          31       31              
  Lines        3154     3156       +2     
==========================================
+ Hits         1634     1639       +5     
+ Misses       1520     1517       -3
Impacted Files Coverage Δ
caliban/platform/cloud/core.py 23.30% <ø> (ø)
caliban/platform/gke/cluster.py 29.75% <ø> (ø)
caliban/platform/run.py 28.44% <ø> (ø)
caliban/util/metrics.py 100.00% <100.00%> (ø)
caliban/platform/gke/util.py 72.13% <0.00%> (+1.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b4cb13...702c47e. Read the comment docs.