search

google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
491 stars 67 forks source link

Move cloud_sql_proxy installation before code copy #87

Closed sritchie closed 4 years ago

sritchie commented 4 years ago

User code changes most frequently, so let's move the cloudsql installation before this step. @ajslone , what do you think?

codecov[bot] commented 4 years ago

Codecov Report

Merging #87 into master will increase coverage by 0.08%. The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   54.23%   54.31%   +0.08%     
==========================================
  Files          31       31              
  Lines        3188     3183       -5     
==========================================
  Hits         1729     1729              
+ Misses       1459     1454       -5
Impacted Files Coverage Δ
caliban/docker/build.py 32.71% <18.18%> (-1.08%) :arrow_down:
caliban/platform/gke/util.py 99.25% <0.00%> (+0.37%) :arrow_up:
caliban/platform/cloud/types.py 90.50% <0.00%> (+0.63%) :arrow_up:
caliban/util/auth.py 76.19% <0.00%> (+9.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 346209a...d9576f8. Read the comment docs.