search

google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
492 stars 67 forks source link

added non-none project check to caliban launcher #88

Closed ajslone closed 4 years ago

ajslone commented 4 years ago

This PR adds a non-none check to the caliban launcher script. This fixes a common error case where a user creates a google.cloud.storage.Client() instance, which fails if no gcp project can be determined automatically. We thus add a check in the launcher script to set a project via the GOOGLE_CLOUD_PROJECT environment variable only in the case where no default project can be determined.

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 1.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   54.31%   55.49%   +1.17%     
==========================================
  Files          31       31              
  Lines        3183     3175       -8     
==========================================
+ Hits         1729     1762      +33     
+ Misses       1454     1413      -41
Impacted Files Coverage Δ
caliban/resources/caliban_launcher.py 100.00% <100.00%> (+66.15%) :arrow_up:
caliban/platform/gke/util.py 99.25% <0.00%> (-0.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e175c2...31784c7. Read the comment docs.