search

google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
492 stars 67 forks source link

modifies caliban stop command to check with user up-front #90

Closed ajslone closed 4 years ago

ajslone commented 4 years ago

This PR modifies the caliban stop command to check with the user up-front rather than after querying running jobs, as this can take a long time, particularly with CAIP jobs. The modified behavior is to verify immediately, then stop all running and submitted jobs in the requested xgroup or user group.

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   54.31%   54.33%   +0.01%     
==========================================
  Files          31       31              
  Lines        3183     3182       -1     
==========================================
  Hits         1729     1729              
+ Misses       1454     1453       -1
Impacted Files Coverage Δ
caliban/history/cli.py 13.40% <0.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e175c2...79f3956. Read the comment docs.