google / caliper

Micro-benchmarking library for Java
Apache License 2.0
816 stars 109 forks source link

Results should not be uploaded to the web by default #356

Open zhaakhi opened 7 years ago

zhaakhi commented 7 years ago

This is a bad idea. It's surprising, there's no advance warning, it's easy to miss that it is happening, and there's no way to delete results after the fact nor anywhere to send a takedown request. It's not even obvious how to disable it!

IMO anonymously uploaded results should be deleted, and new ones should be refused unless the user is indicated to have explicitly opted in. There is no way they can be considered intentionally submitted.

Marcono1234 commented 2 years ago

It's not even obvious how to disable it!

It appears you can either edit your $HOME/.caliper/config.properties file and set results.upload.options.url=, or run with the command line argument -Cresults.upload.options.url=.

Though it would be good if this behavior was opt-in nonetheless.