Build caliper with bazel, and recent deps

google / caliper

Micro-benchmarking library for Java

Apache License 2.0

816 stars 109 forks source link

Build caliper with bazel, and recent deps #434

Open cgruber opened 4 years ago

cgruber commented 4 years ago

This is a trial balloon, to see how the core libraries team feels about it. This PR doesn't delete the maven stuff, nor does it add release scripting based on bazel. It does make a bazel build, artifact version pin list, enables all the tests, and also builds the android worker (which doesn't build on travis in maven today).

TODO:

[ ] Add release scripting for convenient release. (Not a dig, but the last release was years ago, so this may not be a priority)
[ ] Remove obsolete bits related to the maven stuff.
[ ] Update readme and documentation

If this is an acceptable direction, the unfinished bits could be done in this PR or a subsequent one (I'll update this description).

cgruber commented 4 years ago

Further note - just for my own use, I did a "fake release" on my own fork. I don't want to maintain it, but I've made it possible to also USE it from bazel, pretty trivially, and I put instructions in the release

That release does not include any maven artifact release - it only has the full-jar and a command-line wrapper around the full jar, released via the github artifact page on the release itself. This doesn't help general maven-compatible artifact consumption, but at least to roll your own it's possible, if you're willing to risk the "full jar" classpath collision concern (since it's not fully jarjar'ed)

cgdecker commented 4 years ago

Thanks for the PR Christian. FWIW, I think if we were to switch Caliper over to bazel (and we are considering doing that for some or all of our projects, though probably not this year) we'd want to start from the internal BUILD files and add transformations/stripping as needed to produce the external files. That said, I don't really have time for much of anything Caliper-related right now, unfortunately.

Was there something in particular you needed this for? As you've noted, the android worker hasn't been set up to build in open-source, in part because just building it isn't really enough to make the android support I added the other year actually convenient to use in open-source.