Closed sibelius closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I've signed the CLA, I don't know why this does not worked
CLAs look good, thanks!
@yaraki can you take a look on this any time soon?
@sibelius - the code that you used here is BSD licensed: https://github.com/expo/expo/blob/master/LICENSE -- it requires attribution and retaining the copyright notice. I'm not sure how this interacts with Google's CLA here, it might invalidate this PR.
should a put the expo LICENSE on THIRD-PARTY-LICENSES?
I want to know now how to get the preview data , I see there is only method recording video but no one callback the preview frame , some one can help me? @sibelius
@elementlo you should use setScanning(true)
on you CameraView
and then onPreviewFrame
should be invoked within a Callback
you previously added.
@aalices OK , I'll have a try first , thank you.
Hi, When do we have this PR gets merged? I want to do Preview, Recording and Preview frame processing parallel. I hope this PR incorporating those things. For more details, Please find my use case here: https://stackoverflow.com/questions/54091648/camera-2-api-to-preview-record-and-extract-the-preview-frame-to-firebase-face-d
Hey @sibelius, Closed PR without merge, It would be a great help if you can share latest codebase link here. I can't able to find the entria:G
branch here.
We moved our efforts to react native camera, the code and improvements are there
If you want to contribute ther it would be great
Okay, Thanks for the response, So now you are developing the camera stuff into React Native, not in Native Android. That's nice. Atm, I am looking for the Previewing, Recording and Frame processing at the same time. As like I mentioned in my SO question.
You can do that using ML Kit
Yup, But I am unable to extract the Image/Frame when recording is going on. With Preview only, I am getting Image/Frames. Any help/insight will be appreciated on this question: https://stackoverflow.com/questions/54091648/camera-2-api-to-preview-record-and-extract-the-preview-frame-to-firebase-face-d
this is based on @expo work https://github.com/expo/expo/tree/master/android/cameraview
the idea is to consume this package on https://github.com/lwansbrough/react-native-camera (check this https://github.com/lwansbrough/react-native-camera/issues/1031)