google / cap-library

Common Alerting Protocol Library
Apache License 2.0
80 stars 30 forks source link

Improve validation & warnings #39

Closed sschiavoni closed 9 years ago

sschiavoni commented 9 years ago

Original issue 40 created by yuch@google.com on 2013-08-02T23:31:50.000Z:

What steps will reproduce the problem?

: Currently CAP Validator's Googley profile does not throw warnings for the following things (but should)

  1. If the geocode name or value are empty. For example <geocode> <valueName></valueName> <value></value> </geocode>
  2. When it's a test alert. It's valid and fine but sometimes partners send us test alerts that are invalid because they think it's OK <status>Test</status>

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

sschiavoni commented 9 years ago

Comment #1 originally posted by yuch@google.com on 2013-12-05T06:22:20.000Z:

Expected output - throw warnings for both those cases.

sschiavoni commented 9 years ago

This has been fixed sometime in the past.